fix the link to hook #933
Merged
fix the link to hook #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
approved these changes
Oct 26, 2017
There was a problem hiding this comment.
Good catch; I'd missed this in both #838 and #870 :/. There are still two more broken references:
$ git grep -i config.md#hooks origin/pr/933 *.md
origin/pr/933:README.md:[Hook](config.md#hooks) developers can extend the functionality of an OCI-compliant runtime by hooking into a container's lifecycle with an external application.
origin/pr/933:runtime.md:See [runtime configuration for hooks](./config.md#hooks) for more information.
which can either be fixed in this PR or in follow-up work.
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
updated. |
wking
reviewed
Oct 27, 2017
| @@ -137,4 +137,4 @@ Once a container is deleted its ID MAY be used by a subsequent container. | |||
|
|
|||
| ## <a name="runtimeHooks" />Hooks | |||
| Many of the operations specified in this specification have "hooks" that allow for additional actions to be taken before or after each operation. | |||
| See [runtime configuration for hooks](./config.md#hooks) for more information. | |||
| See [runtime configuration for hooks](./config.md#posix-platform-hooks) for more information. | |||
There was a problem hiding this comment.
While we're touching this, I'd drop the useless ./ prefix. But I'm fine with this PR landing without that change.
|
LGTM |
|
ping @crosbymichael PTAL |
|
LGTM Thanks @q384566678 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com