Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Dedent root paragraphs, since they aren't a list entry #936

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

wking
Copy link
Contributor

@wking wking commented Nov 9, 2017

I'd broken this in 2022e3e (#838), where I'd misread the initial bolding ** as a list bullet or something :/. The extra indents don't cause a problem for the first paragraph, but they cause the “On all other platforms…” paragraph to be interpreted as a <pre> block.

I'd broken this in 2022e3e (config: Bump Hyper-V condition from
root.path to root itself, 2017-05-18, opencontainers#838), where I'd misread the
initial bolding ** as a list bullet or something.  The extra indents
don't cause a problem for the first paragraph, but they cause the "On
all other platforms..." paragraph to be interpreted as a <pre> block.

Signed-off-by: W. Trevor King <wking@tremily.us>
Copy link

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hqhq
Copy link
Contributor

hqhq commented Nov 10, 2017

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Nov 10, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit a5b8598 into opencontainers:master Nov 10, 2017
@Mashimiao Mashimiao mentioned this pull request Dec 1, 2017
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Dec 1, 2017
Like 5d9bbad (config: Dedent root paragraphs, since they aren't a
list entry, 2017-11-08, opencontainers#936).  Ma Shimiao pointed out that there may
be more instances of this [1], and this commit fixes all instances
turned up with:

  $ git grep -B1 '^    [^ ]' | grep -A1 '[:-]\*\*'

[1]: opencontainers#934 (comment)

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking deleted the root-dedent branch December 11, 2017 21:07
@vbatts vbatts mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants