uidMappings: change order of fields for clarity #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
added a commit
to kinvolk-archives/runtime-tools
that referenced
this pull request
Mar 8, 2018
The fields of /proc/$pid/uid_map and /proc/$pid/gid_map were parsed in the wrong order. Related: opencontainers/runtime-spec#956 Signed-off-by: Alban Crequy <alban@kinvolk.io>
|
Maybe swap them in the Go structure too? I think (but haven't tested) that Go's default JSON serializer uses the struct's property order for its output. |
|
Just tested and Go's default JSON serializer indeed outputs things in order :) I'll force-push with the swap. |
"man 7 user_namespaces" explains the format of uid_map and gid_map:
<containerID> <hostID> <mapSize>
The order of map entries in JSON does not matter. But for the clarity of
the spec, I find it easier to understand if the order of the JSON fields is
the same as the order of the fields in the underlying uid_map/gid_map
files.
I am about to file a PR in runtime-tools because the fields in
uid_map/gid_map were parsed in the wrong order.
Signed-off-by: Alban Crequy <alban@kinvolk.io>
wking
approved these changes
Mar 8, 2018
|
LGTM (purely cosmetic change) |
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"man 7 user_namespaces" explains the format of uid_map and gid_map:
The order of map entries in JSON does not matter. But for the clarity of
the spec, I find it easier to understand if the order of the JSON fields is
the same as the order of the fields in the underlying uid_map/gid_map
files.
I am about to file a PR in runtime-tools because the fields in
uid_map/gid_map were parsed in the wrong order.
Signed-off-by: Alban Crequy alban@kinvolk.io