config-linux: Add Memory cgroup's use_hierarchy #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crosbymichael Is the Signed-off-by check sensitive to its position in the commit message maybe? I do have it but it's before a Co-authored-by. I swapped the order and force pushed but it doesn't seem to have poked the mechanism to try again. |
|
Not sure. Maybe it wants both to be signed off |
georgethebeatle
force-pushed
the
master
branch
9 times, most recently
from
a33a56f
to
d781cdd
Compare
Co-authored-by: Claudia Beresford <cberesford@pivotal.io> Signed-off-by: Danail Branekov <danailster@gmail.com>
georgethebeatle
force-pushed
the
master
branch
from
d781cdd
to
234aa0b
Compare
|
LGTM |
|
Bump, seems like we another LGTM to get this merged. Once it's in we can work on getting runc to do something with this property. |
|
this doesn't just apply to cgroups v2? perhaps that ought to be clarified that it's for propagating to nested/child groups, regardless to using cgroups of v2. |
|
house keeping: this is an OPTIONAL feature, so non-breaking forward compatible. LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #984
Signed-off-by: Tom Godkin thgodkin@gmail.com
Co-authored-by: Claudia Beresford cberesford@pivotal.io