-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check pointer fields of g.spec #144
Conversation
On Sun, Jul 24, 2016 at 01:25:15PM -0700, hmeng-19 wrote:
I think we want ‘initialize_’ instead of ‘check_’, but the helpers are |
1550024
to
ebaefba
Compare
@wking , you are right. |
Signed-off-by: Haiyan Meng <hmeng@redhat.com>
ebaefba
to
60df8fc
Compare
Travis isn't happy with 889f775, possibly because of #140 landing 1: go build -tags "" -o ocitools ./cmd/ocitools github.com/opencontainers/ocitools/generategenerate/generate.go:444: cannot convert nil to type specs.Linux I have some nil-Linux guards in #112, but they don't cover #137's |
On Tue, Jul 26, 2016 at 08:18:19AM -0700, hmeng-19 wrote:
Ah, looks like you pushed that while I was working on my comment. |
On Tue, Jul 26, 2016 at 10:00:48AM -0700, W. Trevor King wrote:
Actually, #112 still has the empty-Linux JSON serialization change, so |
@wking , sounds good. |
LGTM |
The PR tries to check whether a pointer field is
nil
before modifying the field. This avoids modifying the field of anil
pointer.Signed-off-by: Haiyan Meng hmeng@redhat.com