Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELinux Check #682

Merged
merged 4 commits into from
Feb 18, 2019
Merged

Add SELinux Check #682

merged 4 commits into from
Feb 18, 2019

Conversation

zhouhao3
Copy link

  1. update godeps and add go-selinux deps
  2. add selinux check in validate and runtimetest

Close #386

This is a rebase of #386

Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com
Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

Ma Shimiao added 2 commits January 23, 2019 09:46
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
@zhouhao3 zhouhao3 force-pushed the add-selinux branch 6 times, most recently from 0f241e8 to cce1a4a Compare January 23, 2019 05:16
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Author

@liangchenye PTAL

@liangchenye
Copy link
Member

@q384566678 I'll review it today.

if err != nil {
util.Fatal(err)
}
g.SetLinuxMountLabel("system_u:object_r:svirt_sandbox_file_t:s0:c715,c811")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an 'invalid mount label' test case as well.

@liangchenye
Copy link
Member

liangchenye commented Feb 18, 2019

LGTM

As commented, We need an 'invalid mount label' test case as well.

Approved with PullApprove

@liangchenye liangchenye merged commit d4ec5b8 into opencontainers:master Feb 18, 2019
@zhouhao3 zhouhao3 deleted the add-selinux branch February 19, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants