Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Typos and incorrect defaults #683

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

lowenna
Copy link
Contributor

@lowenna lowenna commented Feb 6, 2019

Signed-off-by: John Howard jhoward@microsoft.com

There were a few typos Winodws which should be Windows (obviously).

It also corrects the defaults for Windows. Neither IgnoreFlushesDuringBoot nor networkings AllowUnqualifiedDNSQuery should be defaulted to true. Also, the assumption that there is a console is incorrect. These should all be set explicitly, if required, by callers.

@jterry75 FYI

Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One addition for ease please

@lowenna lowenna force-pushed the jjh/windowsdefaults branch 3 times, most recently from 1461ce9 to 428e7d6 Compare February 8, 2019 02:22
Signed-off-by: John Howard <jhoward@microsoft.com>
@lowenna lowenna force-pushed the jjh/windowsdefaults branch from 428e7d6 to 3bc60a4 Compare February 8, 2019 02:25
Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowenna
Copy link
Contributor Author

lowenna commented Feb 8, 2019

I'm not sure I understand what's failing in that CI run:

�[0K$ git-validation -run DCO,short-subject -v -range ${TRAVIS_COMMIT_RANGE}
�[31mERRO�[0m[0000] mm[git] cmd: "git --no-pager log --pretty=format:%H f611b4e1e0a8b3ffd9200b35e0f4159838a1c73a...3bc60a442d30ca96277a287c8112ed4dd8541498" 
2019/02/08 02:27:03 exit status 128
travis_time:end:0f7ff500:start=1549592823782128201,finish=1549592823789607319,duration=7479118
�[0K�[31;1mThe command "git-validation -run DCO,short-subject -v -range ${TRAVIS_COMMIT_RANGE}" exited with 1.�[0m

Yet is passes successfully locally:

jhoward@jhoward-p520:/mnt/e/go/src/github.com/opencontainers/runtime-tools$ git-validation -run DCO,short-subject -v -range f611b4e1e0a8b3ffd9200b35e0f4159838a1c73a...3bc60a442d30ca96277a287c8112ed4dd8541498
 * 3bc60a4 "Windows: Typos and incorrect defaults" ... PASS
  - PASS - has a valid DCO
  - PASS - commit subject is 72 characters or less! *yay*
jhoward@jhoward-p520:/mnt/e/go/src/github.com/opencontainers/runtime-tools$

Am I missing something obvious?

@zhouhao3
Copy link

zhouhao3 commented Mar 5, 2019

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit bcea291 into opencontainers:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants