Improve performance of AddProcessEnv #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrunalp PTAL |
|
LGTM |
|
@vbatts ptal |
|
@vbatts ping :) |
rhatdan
reviewed
Apr 16, 2019
| } else { | ||
| // else the env doesn't exist, so add it and add it's index to g.envMap | ||
| g.Config.Process.Env = append(g.Config.Process.Env, env) | ||
| g.envMap[key] = len(g.Config.Process.Env) - 1 |
There was a problem hiding this comment.
Nit: Why not
g.envMap[key] = env
There was a problem hiding this comment.
Because, we want to keep track of the position in the string array this env is at so we can easily go in and update it if an existing env is added again with another value.
generate/generate_test.go
Outdated
| } | ||
| newEnvs := []string{"k1=v1", "k2=v2"} | ||
| expected := []string{"k1=v1", "k2=v2"} | ||
| g.AddMultipleProcessEnv(expected) |
There was a problem hiding this comment.
Nit: This should be newEnvs
vbatts
reviewed
Apr 16, 2019
vbatts
reviewed
Apr 16, 2019
|
couple of thoughts, but otherwise LGTM |
AddProcessEnv was sequentially going through the env array to check for duplicates, which would become very slow if we add a huge amount of ENV vars. Add a map to Generator to keep track of the ENV vars already added, so that when AddProcessEnv checks for duplicates, it is much faster. Also add a new function called AddMultipleProcessEnv, which takes a []string of ENVs and adds them to the config in one go. Add unit tests for these functions. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
@vbatts addresses comments, this should be ready now :) |
|
LGTM |
|
Anything more we need to do to get this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddProcessEnv was sequentially going through the env array
to check for duplicates, which would become very slow if we
add a huge amount of ENV vars.
Add a map to Generator to keep track of the ENV vars already
added, so that when AddProcessEnv checks for duplicates, it is
much faster.
Also add a new function called AddMultipleProcessEnv,
which takes a []string of ENVs and adds them to the config in one
go.
Add unit tests for these functions.
Signed-off-by: Urvashi Mohnani umohnani@redhat.com