runtime-spec: bump to v1.3.0, fixup for backward incompatible linux PIDs limit type change . #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
fixes/spec-linux-pids-limit-is-ptr
branch
2 times, most recently
from
1227392 to
cbbb466
Compare
klihub
changed the title
aojea
reviewed
Nov 4, 2025
aojea
reviewed
Nov 4, 2025
|
ping @cyphar for guidance, since was the author of opencontainers/runtime-spec@869b2d5 |
marquiz
reviewed
Nov 4, 2025
klihub
force-pushed
the
fixes/spec-linux-pids-limit-is-ptr
branch
from
cbbb466 to
4b5fec9
Compare
marquiz
reviewed
Nov 5, 2025
Contributor
marquiz
left a comment
marquiz
left a comment
There was a problem hiding this comment.
One small nit, otherwise looks good to me.
1 task
kolyshkin
reviewed
Nov 6, 2025
kolyshkin
reviewed
Nov 6, 2025
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
Let me bump golangci-lint in a separate PR, as it will be faster than commenting here.
Contributor
|
golangci-lint bump is at #797, PTAL |
Contributor
Author
klihub
force-pushed
the
fixes/spec-linux-pids-limit-is-ptr
branch
from
4b5fec9 to
58c534d
Compare
1 task
Contributor
Bump runtime-spec to v1.3.0. Unfortunately there is a backward incompatible change there switching the Linux PID limit from int64 to *int64. Update generate/generate.go accordingly. Also, add a constant UnlimitedPidsLimit with the correct PID limit indicating "unlimited". Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
fixes/spec-linux-pids-limit-is-ptr
branch
from
35dc18d to
3c27840
Compare
Contributor
Author
|
@kolyshkin Rebased on latest master/HEAD. |
Contributor
Author
|
ping @opencontainers/runtime-tools-maintainers |
Contributor
Author
|
@cyphar @AkihiroSuda @giuseppe PTAL |
1 task
marquiz
reviewed
Nov 11, 2025
kolyshkin
approved these changes
Nov 12, 2025
Contributor
|
If there's anything else that needs to be done, let's do this as a followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps our opencontainers runtime-spec dependency to the latest tagged v1.3.0.
Unfortunately v1.3.0 brings a backward incompatible change, switching the Linux PID limit from int64 to *int64. Make corresponding changes in generate/generate.go. Also, add an
UnlimitedPidsLimit = -1const to codify what is the correct Limit setting for unlimited PIDs.Note: This PR is stacked on #797, a separate PR to bump golangci-lint to v2 and fix existing linter issues.