Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: add go1.19, drop go1.16, update golangci-lint to v1.49 #183

Merged
merged 4 commits into from
Oct 7, 2022
Merged

gha: add go1.19, drop go1.16, update golangci-lint to v1.49 #183

merged 4 commits into from
Oct 7, 2022

Conversation

thaJeztah
Copy link
Member

See individual commits for details

@thaJeztah
Copy link
Member Author

oh! forgot we didn't remove these yet in this repo; let me fix

Error: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)
Error: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)
Error: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)

@thaJeztah
Copy link
Member Author

@kolyshkin @mrunalp PTAL

@thaJeztah thaJeztah mentioned this pull request Oct 6, 2022
Merged
@thaJeztah
remove uses of deprecated io/ioutil
e56e725 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
gha: update to actions/setup-go@v3
6e735e8 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
gha: update golangci-lint to v1.49 for go1.19 compatibility
de069f8 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
gha: add go1.19, drop go1.16
0828a3a 
Both go1.16 and go1.17 reached EOL, but keeping go1.17 for now, for
projects that haven't updated yet.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Oct 7, 2022
Merged
rhatdan
rhatdan approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit 008ae31 into opencontainers:main Oct 7, 2022
@thaJeztah thaJeztah deleted the update_go branch October 7, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhatdan rhatdan rhatdan approved these changes

@kolyshkin kolyshkin Awaiting requested review from kolyshkin kolyshkin is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @rhatdan