Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projects: add umoci proposal #67

Merged
merged 1 commit into from
Jun 15, 2020
Merged

projects: add umoci proposal #67

merged 1 commit into from
Jun 15, 2020

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Feb 15, 2020 •
edited by dmcgowan
Loading

This is long-awaited "merge umoci into OCI" proposal, which has been
discussed in various calls and mailing list threads since the project's
inception in 2016.

Vote Total (Closes 2020-06-12) (please make sure you also leave an LGTM comment):

/cc @opencontainers/tob @opencontainers/image-tools-maintainers @tych0
Signed-off-by: Aleksa Sarai cyphar@cyphar.com

tych0
tych0 reviewed Feb 19, 2020
View reviewed changes
proposals/umoci.md Outdated Show resolved Hide resolved
@tych0
Copy link
Member

tych0 commented Feb 19, 2020

Sounds reasonable to me, other than the one small comment.

@caniszczyk caniszczyk mentioned this pull request Feb 19, 2020
Closed
@cyphar cyphar mentioned this pull request Apr 23, 2020
Closed
@cyphar cyphar mentioned this pull request May 21, 2020
Draft
@jdolitsky jdolitsky mentioned this pull request May 29, 2020
Closed
@vbatts
Copy link
Member

vbatts commented Jun 5, 2020 •
edited
Loading

We need more maintainers, but LGTM

@cyphar
Copy link
Member Author

cyphar commented Jun 5, 2020

Based on @dmcgowan's comments in the TOB call, I will remove this section from this proposal:

In addition, a sub-tree merge (to preserve the history) of the existing image-tools repository

https://github.com/opencontainers/image-tools

will be done into umoci. This will be done to allow the archival of the oci-image-tools repository, as the primary features it has over umoci (specification validation) will be maintained within umoci instead. The purpose of this change is to avoid confusion as to which OCI image tool the OCI is shepherding.

As discussed in the TOB call, we should probably have an OCI Charter amendment (and relevant discussion on process) before we have proposals that involve the archival (whether formal or not) of other OCI projects. Not to mention that we should also discuss whether the oci-image-tools validation code should live in oci-conformance or umoci -- and that should really be a separate proposal. However I am still happy to do the sub-tree merge, this is just to avoid cluttering this proposal with more things than are relevant.

I will also add a few extra points to the FAQ to answer some of @dmcgowan's questions.

@cyphar

This comment has been minimized.

Sign in to view
fuweid
fuweid reviewed Jun 5, 2020
View reviewed changes
proposals/umoci.md Outdated Show resolved Hide resolved
@cyphar
Copy link
Member Author

cyphar commented Jun 5, 2020 •
edited
Loading

Okay, I believe this is ready for a proper vote now (it's been updated based on the TOB call discussion). I've also included @vbatts as a maintainer of the project (I will add him to the MAINTAINERS file if this proposal is accepted, as part of the transition process).

/ping @opencontainers/tob

LGTM from my side (obviously). I do have one question about project votes (which I'm not sure has been brought up before), but I'll put it in a separate issue (see #80).

h-vetinari
h-vetinari reviewed Jun 5, 2020
View reviewed changes
proposals/umoci.md Outdated Show resolved Hide resolved
mikebrow
mikebrow reviewed Jun 6, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non voting
some suggestions for additional detail / clarification

proposals/umoci.md Outdated Show resolved Hide resolved
proposals/umoci.md Outdated Show resolved Hide resolved
proposals/umoci.md Outdated Show resolved Hide resolved
@estesp estesp mentioned this pull request Jun 8, 2020
Closed
9 tasks
@cyphar
Copy link
Member Author

cyphar commented Jun 9, 2020

I have included a new background question and updated the FAQ based on @mikebrow's review. Since I haven't change the text of the proposal I don't believe we need to re-start the voting, but let me know if you'd want to do that @estesp / @caniszczyk.

@estesp
Copy link
Contributor

estesp commented Jun 9, 2020

I don't believe there is any reason to restart the voting. Thanks!

@cyphar cyphar mentioned this pull request Jun 9, 2020
Open
9 tasks
mikebrow
mikebrow reviewed Jun 9, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prior technical issues all addressed
see nit comments..

proposals/umoci.md Outdated Show resolved Hide resolved
proposals/umoci.md Outdated Show resolved Hide resolved
estesp
estesp reviewed Jun 10, 2020
View reviewed changes
proposals/umoci.md Outdated Show resolved Hide resolved
samuelkarp
samuelkarp approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar
Copy link
Member Author

cyphar commented Jun 12, 2020

Just a reminder that this vote closes in 6 hours or so.

/ping @crosbymichael @fuweid @jonjohnsonjr @dmcgowan

fuweid
fuweid approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SteveLasker
SteveLasker previously requested changes Jun 12, 2020
View reviewed changes
proposals/umoci.md Outdated Show resolved Hide resolved
proposals/umoci.md Outdated Show resolved Hide resolved
dmcgowan
dmcgowan previously requested changes Jun 12, 2020
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the vote, but a few minor changes before merging the PR and moving the repository.

proposals/umoci.md Show resolved Hide resolved
@cyphar cyphar dismissed stale reviews from dmcgowan and SteveLasker June 13, 2020 02:11

Simplified the governance section.

@cyphar
projects: add umoci proposal
fe4ccae 
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
SteveLasker
SteveLasker approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The self vs. single lgtm resolved my concern.

@cyphar
Copy link
Member Author

cyphar commented Jun 14, 2020

@caniszczyk I think this is okay to merge now?

@caniszczyk
Copy link
Contributor

caniszczyk commented Jun 14, 2020 via email

@cyphar
Copy link
Member Author

cyphar commented Jun 15, 2020

Invited. I am working on updating the documentation and governance documents, and will probably merge it later today (as well as update the website). Let me know how and when you'd like to do the domain transfer for umo.ci (I only really need admin access to the DNS settings of the domain -- it's currently managed on CloudFlare).

@caniszczyk
Copy link
Contributor

@cyphar repo transfer done: https://github.com/opencontainers/umoci/

Let's sync up over email on the domain transfer, can you unlock the domain and send me the auth code? also dump the zone file if you're doing more than just gh-pages

@caniszczyk caniszczyk merged commit d8b32ae into opencontainers:master Jun 15, 2020
@caniszczyk
Copy link
Contributor

This passes with +1 votes from:

Vincent Batts (@vbatts)
Phil Estes (@estesp)
Wei Fu (@fuweid)
Samuel Karp (@samuelkarp)
Steve Lasker (@SteveLasker)
Derek McGowan (@dmcgowan)
Aleksa Sarai (@cyphar)

@cyphar cyphar deleted the umoci branch June 15, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@mikebrow mikebrow mikebrow left review comments

@tych0 tych0 tych0 left review comments

@fuweid fuweid fuweid approved these changes

@SteveLasker SteveLasker SteveLasker approved these changes

@estesp estesp estesp approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.