Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config to opencontrol #207

Merged
merged 8 commits into from
Jul 26, 2016
Merged

Rename config to opencontrol #207

merged 8 commits into from
Jul 26, 2016

Conversation

jcscottiii
Copy link
Member

@jcscottiii jcscottiii commented Jul 25, 2016

Closes #203

Builds on #206

  • Created a common package inside lib and moved the contents of config/common in there.
    • Other packages were using it, so it makes sense to move it to a broader location and not specifically in config.
  • Renamed lib/config to lib/opencontrol
  • Renamed ResourceGetter to Getter inside the package resources
    • Now, it reads as resources.Getter instead of resources.ResourceGetter
  • Renamed ConfigWorker to Worker.
  • Renamed the interfaceBaseSchema to OpenControl
    • Each version of the opencontrol.yaml will implement the functions of the OpenControl interface.

@codecov-io
Copy link

codecov-io commented Jul 25, 2016

Current coverage is 93.15% (diff: 98.61%)

Merging #207 into master will increase coverage by 1.79%

@@             master       #207   diff @@
==========================================
  Files            33         48    +15   
  Lines          1204       1695   +491   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1100       1579   +479   
- Misses           81         88     +7   
- Partials         23         28     +5   

Powered by Codecov. Last update eb0f849...c8c7ef0

@jcscottiii jcscottiii changed the title [WIP] Rename config to opencontrol Rename config to opencontrol Jul 25, 2016
@jcscottiii
Copy link
Member Author

jcscottiii commented Jul 25, 2016

Ready to review! Will need rebase after #206 is merged

@afeld afeld merged commit 26ad09b into master Jul 26, 2016
@afeld afeld deleted the rename-config-to-opencontrol branch July 26, 2016 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants