Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat chart templates #81

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Reformat chart templates #81

merged 2 commits into from
Jun 27, 2023

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Jun 17, 2023

The PR reformats chart templates to one style with more readable blocks and indents to improve code readability.
Fixed duplicated volumeMounts in main container.

Similar changes: apache/airflow#29917 apache/airflow#29941 apache/airflow#30312 minio/minio#16947 apache/superset#23681

@mattray
Copy link
Collaborator

mattray commented Jun 20, 2023

What formatting tool did you use to reformat everything? There's a lot in there to review and I'd like to see how it was created.

@dnskr
Copy link
Contributor Author

dnskr commented Jun 20, 2023

What formatting tool did you use to reformat everything? There's a lot in there to review and I'd like to see how it was created.

There is no tool for that as I know. It was created manually.

@eric-engberg
Copy link

Just ran into the duplicate volumeMounts. Had to fix it locally to get anything working

Copy link
Collaborator

@toscott toscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Thanks for another round of changes @dnskr!

@toscott toscott merged commit 569f761 into opencost:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants