OCRVS-8278 null extensions cause reindex-search to fail #8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
rikukissa
reviewed
Jan 3, 2025
| @@ -258,6 +258,6 @@ export function findExtension<URL extends AllExtensions['url']>( | |||
| ): Extract<AllExtensions, { url: URL }> | undefined { | |||
| return listOfExtensions.find( | |||
| (extension): extension is Extract<AllExtensions, { url: URL }> => | |||
| extension.url === url | |||
| extension && extension.url === url | |||
There was a problem hiding this comment.
Is there a specific valid case when the extension can be null? As per the type signature of this function, there really should be a case like that. If there is such a case, let's rather ensure null never gets into a list of extensions. Otherwise this will come back to haunt us when we migrate to Events v2 or do any other work with the potentially corrupted data.
|
Root cause fixed in this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle null extensions to resolve the bug raised here: #8278
Still getting a TypeScript error
"Array.find(<anonymous>)"logging in migration microservice from findExtension function in commons but this fix ensures that the reindex passes and we didnt notice any errors in the data.