Check if copysets on chunkservers consistent with mds when check copyset health. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilixiaocui
reviewed
Dec 3, 2020
src/tools/copyset_check_core.cpp
Outdated
| return -1; | ||
| } | ||
| if (copysetsInMds.empty()) return copysets_[kTotal].empty(); | ||
| if (copysets_[kTotal].empty()) return copysetsInMds.empty(); |
There was a problem hiding this comment.
到这里说明两个的copyset数量相等，一个if就可以了？
src/tools/copyset_check_core.cpp
Outdated
| copyset.copysetid()); | ||
| copysetsInMdsGid.insert(gId); | ||
| } | ||
| if (*(copysetsInMdsGid.begin()) != *(copysets_[kTotal].begin()) |
There was a problem hiding this comment.
std::set_difference(v1.begin(), v1.end(), v2.begin(), v2.end(),
std::inserter(diff, diff.begin()));
这个可以比较两者的差异化
xu-chaojie
reviewed
Dec 3, 2020
src/tools/copyset_check_core.cpp
Outdated
| copysetsInMdsGid.insert(gId); | ||
| } | ||
| if (*(copysetsInMdsGid.begin()) != *(copysets_[kTotal].begin()) | ||
| || *(--copysetsInMdsGid.end()) != *(--copysets_[kTotal].end())) { |
bai-charisu
force-pushed
the
check-copyset-with-mds
branch
from
9803492 to
c1997e2
Compare
…sets health Change-Id: I8fdb353323595b583dd2a31f5b6b397b8539bade
bai-charisu
force-pushed
the
check-copyset-with-mds
branch
from
c1997e2 to
02901d2
Compare
ilixiaocui
approved these changes
Dec 3, 2020
xu-chaojie
approved these changes
Dec 3, 2020
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
* CB Q1 blog link updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sets health
Change-Id: I8fdb353323595b583dd2a31f5b6b397b8539bade
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List