-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] upgrade bs image #2629
[feat] upgrade bs image #2629
Conversation
c1e6a8d
to
c103007
Compare
9c22d7b
to
6e5dca1
Compare
cicheck |
d517d90
to
4a45ec5
Compare
cicheck |
@@ -51,6 +55,22 @@ int CurveCluster::InitMdsClient(const curve::client::MetaServerOption &op) { | |||
return mdsClient_->Initialize(op); | |||
} | |||
|
|||
std::vector<char *> VecStr2VecChar(std::vector<std::string> args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about concatenating them into one string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about concatenating them into one string?
will run fail
test/integration/snapshotcloneserver/snapshotcloneserver_common_test.cpp
Show resolved
Hide resolved
@@ -35,7 +35,8 @@ server.snapshotPoolThreadNum=256 | |||
# 快照后台线程扫描等待队列和工作队列的扫描周期(单位:ms) | |||
server.snapshotTaskManagerScanIntervalMs=1000 | |||
# 转储chunk分片大小 | |||
server.chunkSplitSize=1048576 | |||
# for nos, pls set to 1048576 | |||
server.chunkSplitSize=8388608 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xu-chaojie pls check this, if we change the default value, we may encounter compatible problem when upgrading existing cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is no problem
@@ -57,7 +58,8 @@ server.commonPoolThreadNum=256 | |||
# CloneTaskManager 后台线程扫描间隔 | |||
server.cloneTaskManagerScanIntervalMs=1000 | |||
# clone chunk分片大小 | |||
server.cloneChunkSplitSize=65536 | |||
# for nos, pls set to 65536 | |||
server.cloneChunkSplitSize=1048576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
5d5543f
to
a2dd31b
Compare
cicheck |
RUN mkdir -p /etc/curvefs /core /etc/curve && chmod a+x /entrypoint.sh \ | ||
&& cp /curvefs/tools/sbin/curvefs_tool /usr/bin \ | ||
&& cp /curvefs/tools-v2/sbin/curve /usr/bin/ | ||
ENTRYPOINT ["/entrypoint.sh"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is no need any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is no need any more?
it will use parent image entrypoint.
@@ -117,10 +117,10 @@ void FileLockManager::LockInternal(const std::string& path, | |||
|
|||
if (lockType == kRead) { | |||
// get read lock | |||
entry->rwLock_.RDLock(); | |||
bthread_rwlock_rdlock(&entry->rwLock_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why chanage this lock to bthread lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why chanage this lock to bthread lock
The original way will have some problems in the higher version of gcc
cherry-pick this to release1.2.7 ? |
ok |
0. upgrade image frome debian9 to debian11 1. build in docker 2. ut run in docker Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
a2dd31b
to
6375d5e
Compare
cicheck |
2 similar comments
cicheck |
cicheck |
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List