-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PyPy #195
Comments
Sorry for the slow response. I'm not very familiar with PyPy, but for example this issue suggests that PyPy is not yet compatible with the manylinux1 spec. Additionally, this repository seems to be dedicated for building PyPy wheels. Adding PyPy to the matrix would make the maintenance burden too high since it requires (in its current state) a custom environment (at least on Linux) and most likely also a custom package index to which the wheels would be uploaded. |
Hi! I've tried building the package with latest pypy(7.2.0) and it works on ubuntu linux.
I've shared a more detail procedure on reddit here Not wanting to pollute the build matrix, is it possible to upload source version to pypi and let people build on their local environment? If that's possible, I think it'll be nice to accept pypy flag for pip installs. |
Once #43 is solved (see the latest comments, some minor issues related to versioning which is determined during build), we can publish source distribution to PyPI. |
Thx!! That sounds nice. |
@mattip Do I understand it correctly that as of PyPy 7.3.0, PyPy supports
Would this make supporting PyPy3 on Linux easier? Or is this talking more about PyPy itself running on those platforms? |
This means
You still need to build PyPy-specific manylinux wheels, the cpython ones will not load into pypy |
Thanks for the clarification! |
Any update on this? |
can support pypy?, because compile too slow and too complex |
No custom index would be needed. The wheels can be uploaded to PyPI just like numpy does (search for "pp37" on that page). Since this repo builds with github actions and uses
|
Yes, that comment was written over 2 years ago when this repository was using Travis and It looks like NumPy added those pre-built PyPy wheels to PyPI in version 1.19.0 (last year) which makes it now a lot easier to add PyPy support also to these packages. |
has anyone managed to successfully build for windows? I've tried (also setting the same cmake args to point to the correct library and am getting this error: It seems like on windows something is making ninja eliminate the parenthesis (I think it should say C:/Users/Devan/Downloads/pypy3.7-v7.3.4-win64/pypy3.7-v7.3.4-win64libpypy3-c.dll or something along the lines of that, but for some reason ninja is not putting the parenthesis in. |
Are you specifying the location as C:/Users/Devan/Downloads/pypy3.7-v7.3.4-win64/pypy3.7-v7.3.4-win64libpypy3-c.dll or C:\Users\Devan\Downloads\pypy3.7-v7.3.4-win64\pypy3.7-v7.3.4-win64libpypy3-c.dll ? |
I actually managed to fix that issue before I saw this post, but yes, that was basically the problem. I still cannot compile however, as the linker is throwing errors for lots of unresolved external symbols. This leads me to think that somehow the library still didn't register to the linker despite it now correctly appearing in the cmake enviornment variables, but I'm not sure. |
Would a PR to add PyPy to the linux, windows and macos 64 bit platforms overflow the build matrix? If not, I could try to submit one.
something like
is what scipy uses to download and prep a pypy3 environment on circleci
The text was updated successfully, but these errors were encountered: