-
Notifications
You must be signed in to change notification settings - Fork 892
Copy (ffmpeg) .dll to fix #6 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This attempts to copy all .dll files in build directory, where should be only ffmpeg .dll
Use literal style block to avoid unnecessary blank lines http://stackoverflow.com/questions/3790454/in-yaml-how-do-i-break-a-string-over-multiple-lines/21699210#21699210
Fix source dir for ffmpeg .dlls
Note that you have to add rule for copying *.dll in setup.py too so that the files are actually copied inside wheels: https://github.com/skvark/opencv-python/blob/master/setup.py#L33 |
Thanks for the pointer. |
File roller keeps crashing on my Fedora, so I am unable to inspect wheel contents. |
Include ffmpeg .dll into wheel
Need some sanity test for AppVeyor to ensure that it works (no Windows systems right now there). Also need to stuff |
You can add the license to this file in same manner as the BSD license has been added (with a note that cv2 folder contains the FFmpeg dll): https://github.com/skvark/opencv-python/blob/master/LICENSE-3RD-PARTY.txt And it could be useful add a unit test for video reading. If there's e.g. some short mp4 public domain clip it could be added to the test folder and then run simple unit test:
|
I used Chromium test files when I discovered these issues - https://chromium.googlesource.com/chromium/src/+/master/media/test/data/ |
Seems like I am out of time to finish this, so feel free to put the final touches here. |
I did some testing, the video files open fine if the cv2 folder is in Windows PATH. I'll try to solve this... |
@skvark thanks! I am still unable to get more time for OpenCV. Now people will have less trouble trying to follow https://www.youtube.com/watch?v=MC00XWdl-ms =) |
This attempts to copy all .dll files in build directory,
where should be only ffmpeg .dll