Skip to content

Copy (ffmpeg) .dll to fix #6 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 24, 2016
Merged

Copy (ffmpeg) .dll to fix #6 #15

merged 9 commits into from
Sep 24, 2016

Conversation

techtonik
Copy link
Contributor

This attempts to copy all .dll files in build directory,
where should be only ffmpeg .dll

This attempts to copy all .dll files in build directory,
where should be only ffmpeg .dll
Fix source dir for ffmpeg .dlls
@skvark
Copy link
Member

skvark commented Sep 21, 2016

Note that you have to add rule for copying *.dll in setup.py too so that the files are actually copied inside wheels:

https://github.com/skvark/opencv-python/blob/master/setup.py#L33

@techtonik
Copy link
Contributor Author

Thanks for the pointer.

@techtonik
Copy link
Contributor Author

File roller keeps crashing on my Fedora, so I am unable to inspect wheel contents.

Include ffmpeg .dll into wheel
@techtonik
Copy link
Contributor Author

Need some sanity test for AppVeyor to ensure that it works (no Windows systems right now there).

Also need to stuff ffmpeg license somewhere..

@skvark
Copy link
Member

skvark commented Sep 21, 2016

You can add the license to this file in same manner as the BSD license has been added (with a note that cv2 folder contains the FFmpeg dll): https://github.com/skvark/opencv-python/blob/master/LICENSE-3RD-PARTY.txt

And it could be useful add a unit test for video reading. If there's e.g. some short mp4 public domain clip it could be added to the test folder and then run simple unit test:

import cv2

cap = cv2.videoCapture("filename.mp4")
self.assertTrue(cap.isOpened())

@skvark
Copy link
Member

skvark commented Sep 21, 2016

Wheels contain now both dlls, wildcard pattern needs to be modifed.

cv2

@techtonik
Copy link
Contributor Author

I used Chromium test files when I discovered these issues - https://chromium.googlesource.com/chromium/src/+/master/media/test/data/

@techtonik
Copy link
Contributor Author

Seems like I am out of time to finish this, so feel free to put the final touches here.

@skvark
Copy link
Member

skvark commented Sep 24, 2016

I did some testing, the video files open fine if the cv2 folder is in Windows PATH. I'll try to solve this...

@skvark skvark merged commit 68fc11e into opencv:master Sep 24, 2016
@techtonik
Copy link
Contributor Author

@skvark thanks! I am still unable to get more time for OpenCV.

Now people will have less trouble trying to follow https://www.youtube.com/watch?v=MC00XWdl-ms =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants