-
-
Notifications
You must be signed in to change notification settings - Fork 56.4k
warpFrame() fixed & covered by tests #22150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2. refactored funcptrs to switch/cases & more
|
ARM version fails on tests: |
| Vec3d v; | ||
| if (!badz) | ||
| { | ||
| // Reproject pixel (x, y) using known z, rotate+translate and project back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to add the formulas to Doxygen description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See no sense in this: these formulas explain the code, there's no any other sense in them.
asmorkalov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@asmorkalov the corresponding PR in extra should be merged too |
This PR contains:
warpFrame()which is fixed to work the same regardless of depth scalewarpFrame()Connected test data & generation script PR: #985@extra
API note
CV_16Stype support for depth was removed since it's quite exotic and its valid value range is twice smaller than ofCV_16UCV_8UC1,CV_8UC3,CV_8UC4The reasons are:
TODOs:
warpFrame()in testsPull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.