Skip to content

Conversation

@AleksandrPanov
Copy link
Contributor

@AleksandrPanov AleksandrPanov commented Mar 3, 2024

merge with opencv/opencv_extra#1153

Added a full pipeline tests:

  1. detector->process(img, (TYPECHART)0, 1, true);
  2. ColorCorrectionModel model(src, COLORCHECKER_Macbeth); model.run();
  3. calibratedImage = model.infer(calibratedImage)*255.;

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov added test category: mcc color calibration module labels Mar 3, 2024
@AleksandrPanov AleksandrPanov force-pushed the add_to_mcc_detect_and_infer_test branch from dbc62de to e137ad6 Compare March 3, 2024 22:08
@AleksandrPanov AleksandrPanov mentioned this pull request Mar 3, 2024
6 tasks
@AleksandrPanov AleksandrPanov force-pushed the add_to_mcc_detect_and_infer_test branch 4 times, most recently from cc8e881 to 8ecd981 Compare March 4, 2024 12:52
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. What if split the test on two: detector and infer separately. It's easier for debugging in case of an issue.

@AleksandrPanov AleksandrPanov force-pushed the add_to_mcc_detect_and_infer_test branch from 8ecd981 to 9cbea18 Compare March 5, 2024 19:12
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AleksandrPanov AleksandrPanov force-pushed the add_to_mcc_detect_and_infer_test branch from 9334e79 to 18d2c29 Compare March 6, 2024 08:52
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 6b5142f into opencv:4.x Mar 7, 2024
@asmorkalov asmorkalov mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: mcc color calibration module test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants