Skip to content

Conversation

@vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Jan 13, 2025

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@vrabaud vrabaud added the cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) label Jan 13, 2025
@vrabaud
Copy link
Contributor Author

vrabaud commented Jan 14, 2025

@mshabunin , this is similar to opencv/opencv#26763 . The "default" CI failure was before I pushed fixes to opencv/opencv

@mshabunin
Copy link
Contributor

It looks like a strange merge issue - CI uses your remove_c branch from the opencv repository and results of merge on GHA and buildbot are different. Please try to remove remove_c branch from your opencv fork and force push to this PR to restart CI builds.

The cvInvSqrt code replacement is taken from 5.x
@vrabaud
Copy link
Contributor Author

vrabaud commented Jan 14, 2025

Done, it seems to pass now

@asmorkalov asmorkalov merged commit ac9ef6c into opencv:4.x Jan 15, 2025
11 checks passed
@vrabaud vrabaud deleted the remove_c branch January 15, 2025 16:15
@asmorkalov asmorkalov mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants