Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache same STIX bundle more than once #225

Merged
merged 1 commit into from
May 11, 2022

Conversation

pcoccoli
Copy link
Collaborator

Mitigates (but does not resolve) #207

@pcoccoli pcoccoli requested a review from subbyte May 10, 2022 20:22
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #225 (5c53787) into develop (fc6e1e1) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #225      +/-   ##
===========================================
+ Coverage    78.83%   78.90%   +0.07%     
===========================================
  Files           38       38              
  Lines         2353     2361       +8     
===========================================
+ Hits          1855     1863       +8     
  Misses         498      498              
Impacted Files Coverage Δ
src/kestrel_datasource_stixbundle/interface.py 65.65% <100.00%> (+2.21%) ⬆️
src/kestrel/session.py 90.00% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6e1e1...5c53787. Read the comment docs.

@pcoccoli pcoccoli merged commit 5fcc399 into develop May 11, 2022
@pcoccoli pcoccoli deleted the only_cache_bundle_once branch May 11, 2022 14:40
@pcoccoli pcoccoli mentioned this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants