Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocsf schema support in aws Athena #1134

Merged
merged 15 commits into from
Oct 27, 2022
Merged

ocsf schema support in aws Athena #1134

merged 15 commits into from
Oct 27, 2022

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Sep 28, 2022

No description provided.

@mdazam1942 mdazam1942 changed the title Ocsf aws ocsf schema support in aws Athena Oct 19, 2022
@mdazam1942 mdazam1942 marked this pull request as ready for review October 19, 2022 18:26
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 64.26% // Head: 64.22% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (7a7494f) compared to base (67473af).
Patch coverage: 85.07% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1134      +/-   ##
===========================================
- Coverage    64.26%   64.22%   -0.04%     
===========================================
  Files          556      556              
  Lines        54263    54369     +106     
===========================================
+ Hits         34870    34918      +48     
- Misses       19393    19451      +58     
Impacted Files Coverage Δ
.../aws_athena/stix_transmission/results_connector.py 88.94% <44.44%> (-2.31%) ⬇️
...es/aws_athena/stix_transmission/query_connector.py 54.44% <62.50%> (-4.53%) ⬇️
...s/aws_athena/stix_translation/query_constructor.py 65.78% <86.66%> (-1.26%) ⬇️
...s/stix_translation/test_aws_athena_json_to_stix.py 38.65% <100.00%> (+3.32%) ⬆️
.../stix_translation/test_aws_athena_stix_to_query.py 57.36% <100.00%> (-3.47%) ⬇️
...lation/src/json_to_stix/json_to_stix_translator.py 78.63% <100.00%> (+0.12%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 requested a review from delliott90 October 24, 2022 12:51
@mdazam1942 mdazam1942 merged commit 73b7ccb into develop Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants