Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp chronicle: removed an invalid unittest #1166

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

mdazam1942
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 64.26% // Head: 64.21% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (c7c2fb6) compared to base (67473af).
Patch coverage: 85.07% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1166      +/-   ##
===========================================
- Coverage    64.26%   64.21%   -0.05%     
===========================================
  Files          556      556              
  Lines        54263    54363     +100     
===========================================
+ Hits         34870    34911      +41     
- Misses       19393    19452      +59     
Impacted Files Coverage Δ
...ix_translation/test_gcp_chronicle_stix_to_query.py 93.26% <ø> (-0.15%) ⬇️
.../aws_athena/stix_transmission/results_connector.py 88.94% <44.44%> (-2.31%) ⬇️
...es/aws_athena/stix_transmission/query_connector.py 54.44% <62.50%> (-4.53%) ⬇️
...s/aws_athena/stix_translation/query_constructor.py 65.78% <86.66%> (-1.26%) ⬇️
...s/stix_translation/test_aws_athena_json_to_stix.py 38.65% <100.00%> (+3.32%) ⬆️
.../stix_translation/test_aws_athena_stix_to_query.py 57.36% <100.00%> (-3.47%) ⬇️
...lation/src/json_to_stix/json_to_stix_translator.py 78.63% <100.00%> (+0.12%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 merged commit c06b8f3 into develop Oct 27, 2022
@mdazam1942 mdazam1942 deleted the gcp_unittest_fix branch October 27, 2022 18:29
baulus pushed a commit that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants