Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pagination and meta files delete for aws athena #1176

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Nov 3, 2022

No description provided.

@baulus baulus marked this pull request as ready for review November 4, 2022 14:08
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 84.75% // Head: 84.72% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (ec6e99f) compared to base (9cb6a13).
Patch coverage: 78.87% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1176      +/-   ##
===========================================
- Coverage    84.75%   84.72%   -0.03%     
===========================================
  Files          556      556              
  Lines        41261    41287      +26     
===========================================
+ Hits         34969    34982      +13     
- Misses        6292     6305      +13     
Impacted Files Coverage Δ
.../stix_translation/test_aws_athena_stix_to_query.py 100.00% <ø> (ø)
.../aws_athena/stix_transmission/results_connector.py 88.15% <77.94%> (-3.70%) ⬇️
...s/aws_athena/stix_translation/query_constructor.py 90.14% <100.00%> (-0.04%) ⬇️
..._athena/tests/stix_transmission/test_aws_athena.py 94.16% <100.00%> (-1.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 merged commit 88293b4 into develop Nov 4, 2022
@mdazam1942 mdazam1942 deleted the aws_athena_pagination_fix branch November 4, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants