Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS Athena for OCSF schema support #1178

Merged
merged 14 commits into from
Nov 9, 2022

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Nov 7, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 84.72% // Head: 84.63% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (3e6ff80) compared to base (fa8aa6c).
Patch coverage: 25.71% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1178      +/-   ##
===========================================
- Coverage    84.72%   84.63%   -0.10%     
===========================================
  Files          556      557       +1     
  Lines        41287    41348      +61     
===========================================
+ Hits         34982    34995      +13     
- Misses        6305     6353      +48     
Impacted Files Coverage Δ
.../aws_athena/stix_transmission/results_connector.py 85.71% <0.00%> (-2.44%) ⬇️
...es/aws_athena/stix_transmission/query_connector.py 55.78% <17.94%> (-23.25%) ⬇️
...odules/aws_athena/stix_translation/transformers.py 38.09% <38.09%> (ø)
...s/aws_athena/stix_translation/query_constructor.py 90.14% <100.00%> (ø)
.../stix_translation/test_aws_athena_stix_to_query.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 marked this pull request as ready for review November 8, 2022 15:54
@mdazam1942 mdazam1942 force-pushed the aws_athena_ocsf_all_values branch from 197bacd to 7dbaf70 Compare November 8, 2022 17:42
@mdazam1942 mdazam1942 changed the title Aws athena ocsf all values Update AWS Athena for OCSF schema support Nov 9, 2022
@mdazam1942 mdazam1942 merged commit 2e87d53 into develop Nov 9, 2022
@mdazam1942 mdazam1942 deleted the aws_athena_ocsf_all_values branch November 9, 2022 16:02
baulus pushed a commit that referenced this pull request Dec 7, 2022
Co-authored-by: Md Azam <mdazam@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants