Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cybereason code to fix the issue #1215 #1224

Conversation

thangaraj-ramesh
Copy link
Contributor

  1. Changes done to treat both AND as OR operator between multiple observations.
  2. Updated code to display alternate error message "Cybereason does not support AND operator between fields" when unsupported Cybereason fields are attempted to be combined using AND operator. Added relevant unit test cases.

1. Changes  done to treat both AND  as OR operator between multiple observations.
2. Updated code to display alternate error message "Cybereason does not support AND operator between fields" when unsupported Cybereason fields are attempted to be combined using AND operator.
Added relevant unit test cases.
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 84.66% // Head: 84.68% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (22ffcf2) compared to base (e904922).
Patch coverage: 98.57% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1224      +/-   ##
===========================================
+ Coverage    84.66%   84.68%   +0.02%     
===========================================
  Files          557      557              
  Lines        41435    41490      +55     
===========================================
+ Hits         35080    35135      +55     
  Misses        6355     6355              
Impacted Files Coverage Δ
...odules/darktrace/stix_transmission/error_mapper.py 100.00% <ø> (ø)
...r_modules/darktrace/stix_transmission/connector.py 93.43% <91.66%> (+0.51%) ⬆️
...s/cybereason/stix_translation/query_constructor.py 95.11% <100.00%> (+0.31%) ⬆️
.../stix_translation/test_cybereason_stix_to_query.py 98.93% <100.00%> (+0.02%) ⬆️
...darktrace/test/stix_transmission/test_darktrace.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90 delliott90 merged commit c1f8926 into opencybersecurityalliance:develop Dec 5, 2022
baulus pushed a commit that referenced this pull request Dec 7, 2022
1. Changes  done to treat both AND  as OR operator between multiple observations.
2. Updated code to display alternate error message "Cybereason does not support AND operator between fields" when unsupported Cybereason fields are attempted to be combined using AND operator.
Added relevant unit test cases.
delliott90 pushed a commit that referenced this pull request Dec 13, 2022
1. Changes  done to treat both AND  as OR operator between multiple observations.
2. Updated code to display alternate error message "Cybereason does not support AND operator between fields" when unsupported Cybereason fields are attempted to be combined using AND operator.
Added relevant unit test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants