Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base release5.0.x - Cookies are handled for cybereason asynchronous c… #1313

Conversation

thangaraj-ramesh
Copy link
Contributor

Cookies are handled for cybereason asynchronous changes

…hanges

Cookies are handled for cybereason asynchronous changes
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 84.87% // Head: 84.85% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (fd12170) compared to base (e2b6a18).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/5.0.x    #1313      +/-   ##
=================================================
- Coverage          84.87%   84.85%   -0.02%     
=================================================
  Files                575      575              
  Lines              42581    42599      +18     
=================================================
+ Hits               36142    36149       +7     
- Misses              6439     6450      +11     
Impacted Files Coverage Δ
...modules/cybereason/stix_transmission/api_client.py 51.35% <14.28%> (-6.23%) ⬇️
..._modules/cybereason/stix_transmission/connector.py 84.76% <100.00%> (-7.62%) ⬇️
...nelone/tests/stix_transmission/test_sentinelone.py 100.00% <0.00%> (ø)
.../stix_translation/test_elastic_ecs_json_to_stix.py 100.00% <0.00%> (ø)
...elastic_ecs/stix_translation/results_translator.py 100.00% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

raise InvalidAuthenticationException
response_code = response.code
response_dict = json.loads(response.read().decode('utf-8'))
response_dict = json.loads(response.content)
Copy link
Contributor

@baulus baulus Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for this?
If not, please, change this back to response.read().decode('utf-8').
The rest looks good, thank you!

Copy link
Contributor Author

@thangaraj-ramesh thangaraj-ramesh Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both provide the same results, but we can directly get the response status from the content without having to decode the data. We have reverted this back as per your suggestion

decoded the response content
@baulus baulus self-requested a review February 7, 2023 13:18
@mdazam1942 mdazam1942 merged commit 5de5810 into opencybersecurityalliance:release/5.0.x Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants