-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base release5.0.x - Cookies are handled for cybereason asynchronous c… #1313
base release5.0.x - Cookies are handled for cybereason asynchronous c… #1313
Conversation
…hanges Cookies are handled for cybereason asynchronous changes
Codecov ReportBase: 84.87% // Head: 84.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/5.0.x #1313 +/- ##
=================================================
- Coverage 84.87% 84.85% -0.02%
=================================================
Files 575 575
Lines 42581 42599 +18
=================================================
+ Hits 36142 36149 +7
- Misses 6439 6450 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
raise InvalidAuthenticationException | ||
response_code = response.code | ||
response_dict = json.loads(response.read().decode('utf-8')) | ||
response_dict = json.loads(response.content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for this?
If not, please, change this back to response.read().decode('utf-8')
.
The rest looks good, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both provide the same results, but we can directly get the response status from the content without having to decode the data. We have reverted this back as per your suggestion
decoded the response content
Cookies are handled for cybereason asynchronous changes