cybereason quick ping #1350
Merged
cybereason quick ping #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1350 +/- ##
===========================================
- Coverage 85.43% 85.42% -0.02%
===========================================
Files 569 569
Lines 42734 42746 +12
===========================================
+ Hits 36511 36514 +3
- Misses 6223 6232 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mdazam1942
reviewed
Feb 27, 2023
| response_code = response.code | ||
| if response_code == 302: | ||
| raise InvalidAuthenticationException | ||
| if response_code == 405: |
There was a problem hiding this comment.
Setting 405 as success seems odd.
mdazam1942
reviewed
Feb 27, 2023
stix_shifter_modules/cybereason/stix_transmission/api_client.py
Outdated
Show resolved
Hide resolved
mdazam1942
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.