Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1375, optimize get_pagesize() function call, and add testcases #1384

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

tingdai
Copy link
Collaborator

@tingdai tingdai commented Mar 10, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 97.14% and project coverage change: +0.03 🎉

Comparison is base (e6b1c61) 85.20% compared to head (2e6a95e) 85.24%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1384      +/-   ##
===========================================
+ Coverage    85.20%   85.24%   +0.03%     
===========================================
  Files          585      585              
  Lines        43738    43750      +12     
===========================================
+ Hits         37267    37293      +26     
+ Misses        6471     6457      -14     
Impacted Files Coverage Δ
...modules/elastic_ecs/stix_transmission/connector.py 76.84% <92.85%> (+3.10%) ⬆️
...odules/elastic_ecs/stix_transmission/api_client.py 79.03% <100.00%> (+15.54%) ⬆️
...ic_ecs/tests/stix_transmission/test_elastic_ecs.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@delliott90 delliott90 merged commit 47a1811 into opencybersecurityalliance:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants