-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splunk: Fix MAC address to display in proper STIX format #1386
Splunk: Fix MAC address to display in proper STIX format #1386
Conversation
Added transformer to handle any MAC value into Stix format. Added new unit test cases. Added missed async await in api_client.
corrected test cases of build issue
Can you rename this PR to something that would make sense to the open source community? This is an open project and no one knows what CP4SCORE-24254 means. |
We actually generate our CHANGELOGS from the merge commits on the PRs https://github.com/opencybersecurityalliance/stix-shifter/blob/develop/CHANGELOG.md |
As suggested PR is renamed. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1386 +/- ##
===========================================
+ Coverage 85.23% 85.24% +0.01%
===========================================
Files 585 585
Lines 43758 43771 +13
===========================================
+ Hits 37298 37314 +16
+ Misses 6460 6457 -3
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
corrected the maclength variable spelling.
As suggested Mac address allowed literal changed to [A-Fa-f0-9]. A typo error in api_client file is corrected(character ] removed).
Added transformer to handle any MAC value into Stix format. Added new unit test cases.
Added missed async await in api_client.