Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Athena error handling, error log printing in tranlsation #1415

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Apr 3, 2023

This will fix:

  1. Error handling message and code when AWS Athena connection has non-existing/none-accessible DB/tables
  2. Error line printing in to_stix translation that has a non descriptive error, example: "string indices must be integers"

@baulus baulus requested review from delliott90 and mdazam1942 April 3, 2023 15:20
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 65.62% and project coverage change: -0.01 ⚠️

Comparison is base (8788d25) 85.25% compared to head (abe3f29) 85.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1415      +/-   ##
===========================================
- Coverage    85.25%   85.25%   -0.01%     
===========================================
  Files          585      585              
  Lines        43816    43830      +14     
===========================================
+ Hits         37356    37366      +10     
- Misses        6460     6464       +4     
Impacted Files Coverage Δ
...es/aws_athena/stix_transmission/query_connector.py 49.07% <0.00%> (-0.93%) ⬇️
...lation/src/json_to_stix/json_to_stix_translator.py 90.46% <68.00%> (-0.42%) ⬇️
stix_shifter_utils/utils/logger.py 73.07% <100.00%> (+4.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 merged commit 2216c7c into develop Apr 5, 2023
@mdazam1942 mdazam1942 deleted the athena-and-translation-error-pronting branch April 5, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants