Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okta Error Code Mapping Changes for develop Branch #1434

Conversation

SharmilaMS-Hcl
Copy link
Contributor

1.Modified the error mapper with TRANSMISSION_AUTH_CREDENTIALS for invalid Api token (401 error code) and added the timeout parameter in api_client.py file.
2.Updated unit test cases for the same.

1.Modified the error mapper with TRANSMISSION_AUTH_CREDENTIALS for invalid Api token (401 error code) and added the timeout parameter in api_client.py file.
2.Updated unit test cases for the same.
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14 ⚠️

Comparison is base (62457c2) 85.37% compared to head (f0c3a7e) 85.23%.

❗ Current head f0c3a7e differs from pull request most recent head cbd6dc8. Consider uploading reports for the commit cbd6dc8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1434      +/-   ##
===========================================
- Coverage    85.37%   85.23%   -0.14%     
===========================================
  Files          589      585       -4     
  Lines        44541    43777     -764     
===========================================
- Hits         38028    37315     -713     
+ Misses        6513     6462      -51     
Impacted Files Coverage Δ
...ter_modules/okta/stix_transmission/error_mapper.py 100.00% <ø> (ø)
...ifter_modules/okta/stix_transmission/api_client.py 100.00% <100.00%> (ø)
...r_modules/okta/test/stix_transmission/test_okta.py 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 merged commit 319c404 into opencybersecurityalliance:develop Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants