Framework Changes for Handling Nested List of Dictionaries #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SharmilaMS-Hcl
commented
Jun 23, 2023
SharmilaMS-Hcl
commented
- Added changes in json_to_stix_tranlsator.py file to handle the nested list of dictionaries.
- Handled the failed unit test cases of the connectors based on the framework changes.
1. Added changes in json_to_stix_tranlsator.py file to handle the nested list of dictionaries. 2. Handled the failed unit test cases of the connectors based on the framework changes.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1516 +/- ##
========================================
Coverage 85.32% 85.32%
========================================
Files 672 672
Lines 54071 54088 +17
========================================
+ Hits 46136 46152 +16
- Misses 7935 7936 +1
☔ View full report in Codecov by Sentry. |
Updated stix_shifter.py file which has the changes to handle serialization failure of datetime.datetime object
mdazam1942
reviewed
Jul 10, 2023
mdazam1942
reviewed
Jul 10, 2023
stix_shifter_modules/aws_guardduty/stix_translation/results_translator.py
Outdated
Show resolved
Hide resolved
mdazam1942
reviewed
Jul 10, 2023
|
looks like there's conflict in stix_shifter_utils/stix_translation/src/json_to_stix/json_to_stix_translator.py |
…e/stix-shifter into aws_guarddduty_v1 # Conflicts: # stix_shifter_utils/stix_translation/src/json_to_stix/json_to_stix_translator.py
1. Removed Guardduty related changes. 2. Retained Framework related changes alone for Handling Nested objects. 3. Fixed the failing unit tests related to Framework/common file changes.
SharmilaMS-Hcl
added a commit
to SharmilaMS-Hcl/stix-shifter
that referenced
this pull request
Jul 11, 2023
1. Added files for AWS GuardDuty UDI Connector module 2. Added the following files related to PR opencybersecurityalliance#1516 to avoid CI failures. 1. json_to_stix_translator.py 2. gcp chronicle Read me, to-stix and unit test case files 3. Reaqta unit test case file. 3. Updated stix_shifter.py file for handling serialization failure of datetime.datetime object.
mdazam1942
approved these changes
Jul 14, 2023
baulus
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.