-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectra UDI connector #1530
Merged
mdazam1942
merged 21 commits into
opencybersecurityalliance:develop
from
thangaraj-ramesh:vectra_v1
Aug 23, 2023
Merged
Vectra UDI connector #1530
mdazam1942
merged 21 commits into
opencybersecurityalliance:develop
from
thangaraj-ramesh:vectra_v1
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Vectra UDI connector
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1530 +/- ##
===========================================
+ Coverage 85.75% 85.93% +0.18%
===========================================
Files 551 561 +10
Lines 46334 47522 +1188
===========================================
+ Hits 39734 40840 +1106
- Misses 6600 6682 +82
☔ View full report in Codecov by Sentry. |
mdazam1942
reviewed
Jul 24, 2023
mdazam1942
reviewed
Jul 24, 2023
Updated code to correct the page number calculation
Mapping validator errors resolved
Dummy check in - restarting code coverage
mdazam1942
reviewed
Jul 27, 2023
stix_shifter_modules/vectra/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
mdazam1942
reviewed
Jul 27, 2023
stix_shifter_modules/vectra/stix_translation/query_constructor.py
Outdated
Show resolved
Hide resolved
mdazam1942
reviewed
Jul 27, 2023
mdazam1942
reviewed
Jul 27, 2023
Removed default result limit
Pagination handled using metadata and src_ip referred in network object
mdazam1942
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Vectra UDI connector