Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: case-insensitive bug for items in brackets for elastic_ecs. #1606

Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix: case-insensitive bug for items in brackets for elastic_ecs. #1606

merged 2 commits into from
Oct 19, 2023

Conversation

subbyte
Copy link
Member

@subbyte subbyte commented Oct 18, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...stix_translation/test_elastic_ecs_stix_to_query.py 97.95% <100.00%> (+0.02%) ⬆️
.../elastic_ecs/stix_translation/query_constructor.py 96.11% <97.22%> (-0.05%) ⬇️

📢 Thoughts on this report? Let us know!.

@mdazam1942 mdazam1942 linked an issue Oct 19, 2023 that may be closed by this pull request
case-insensitive bug for items in brackets for elastic_ecs #1605
Closed
@mdazam1942 mdazam1942 changed the title fix #1605 + more tests fix: case-insensitive bug for items in brackets for elastic_ecs. Oct 19, 2023
@mdazam1942 mdazam1942 self-requested a review October 19, 2023 12:19
@mdazam1942 mdazam1942 merged commit ba4d7d6 into opencybersecurityalliance:develop Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdazam1942 mdazam1942 mdazam1942 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

case-insensitive bug for items in brackets for elastic_ecs
2 participants
@subbyte @mdazam1942