Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sumologic: use milliseconds since epoch for timestamps #1668

Conversation

pcoccoli
Copy link
Contributor

Fixes #1659

@pcoccoli pcoccoli requested a review from mdazam1942 March 19, 2024 15:14
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.25%. Comparing base (710af9e) to head (0f57817).

Files Patch % Lines
...es/sumologic/stix_translation/query_constructor.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1668   +/-   ##
========================================
  Coverage    86.25%   86.25%           
========================================
  Files          586      586           
  Lines        50024    50035   +11     
========================================
+ Hits         43148    43158   +10     
- Misses        6876     6877    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mdazam1942 mdazam1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's a conflict because of the previous sumo logic pr

@pcoccoli pcoccoli requested a review from mdazam1942 March 21, 2024 20:28
@mdazam1942 mdazam1942 merged commit ffb01c4 into opencybersecurityalliance:develop Mar 22, 2024
5 checks passed
@pcoccoli pcoccoli deleted the issue_1659_sumologic_timestamp branch March 22, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Timestamp format in Sumologic Module
2 participants