Added the ability to enable trusted_env. #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DerekRushton <derek.rushton1@ibm.com>
benjamin-craig
approved these changes
Aug 26, 2024
stix_shifter_utils/stix_transmission/utils/RestApiClientAsync.py
Outdated
Show resolved
Hide resolved
stix_shifter_utils/stix_transmission/utils/RestApiClientAsync.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1727 +/- ##
===========================================
- Coverage 87.22% 87.22% -0.01%
===========================================
Files 645 645
Lines 56370 56375 +5
===========================================
+ Hits 49171 49175 +4
- Misses 7199 7200 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: DerekRushton <derek.rushton1@ibm.com>
| #To enable proxy, set the environment variable "STIX_SHIFTER_ENABLE_TRUST_ENV" to true. This option will allow the connection | ||
| #to use the system environments proxy settings. This can be done by setting the "https_proxy" environment variable to | ||
| #"http(s)://[username]:[password]@[hostname]/[ipaddress]:[port]". Alternative proxy schema's may or may not work. | ||
| self.trust_env_enabled = os.environ.get("STIX_SHIFTER_ENABLE_TRUST_ENV", False).lower() |
There was a problem hiding this comment.
Do you think STIX_SHIFTER_ENABLE_TRUST_PROXY_ENV would be more descriptive or just leave it as it is ?
There was a problem hiding this comment.
I think we need to remove the .lower there.
benjamin-craig
approved these changes
Aug 26, 2024
Signed-off-by: DerekRushton <derek.rushton1@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.