Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local build and install, originally by jiyongj #779

Merged
merged 17 commits into from
Feb 3, 2022
Merged

Conversation

baulus
Copy link
Contributor

@baulus baulus commented Jan 17, 2022

The original issue description is here
#620

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #779 (153280d) into develop (81f32a5) will increase coverage by 0.00%.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #779   +/-   ##
========================================
  Coverage    64.04%   64.04%           
========================================
  Files          436      436           
  Lines        38703    38711    +8     
========================================
+ Hits         24786    24793    +7     
- Misses       13917    13918    +1     
Impacted Files Coverage Δ
stix_shifter_utils/utils/module_discovery.py 90.90% <50.00%> (+0.21%) ⬆️
stix_shifter_utils/utils/param_validator.py 64.03% <77.77%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f32a5...153280d. Read the comment docs.

@yurii-klymenko
Copy link
Collaborator

You need to update the development documentation @baulus

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mdazam1942 mdazam1942 merged commit cb04e02 into develop Feb 3, 2022
@mdazam1942 mdazam1942 deleted the local-build branch February 3, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants