Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splunk: fix incorrect dst_ref.value mapping [#919] #970

Merged
merged 2 commits into from
May 31, 2022

Conversation

pcoccoli
Copy link
Contributor

@pcoccoli pcoccoli commented May 27, 2022

Closes #919

@pcoccoli pcoccoli requested review from delliott90 and mdazam1942 May 27, 2022 15:34
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #970 (ffa8d14) into develop (d6d47f0) will increase coverage by 0.78%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #970      +/-   ##
===========================================
+ Coverage    65.24%   66.02%   +0.78%     
===========================================
  Files          517      517              
  Lines        48452    47885     -567     
===========================================
+ Hits         31612    31617       +5     
+ Misses       16840    16268     -572     
Impacted Files Coverage Δ
.../tests/stix_translation/test_splunk_stix_to_spl.py 86.93% <100.00%> (+12.59%) ⬆️
...ter_utils/stix_transmission/utils/RestApiClient.py 53.29% <0.00%> (-4.10%) ⬇️
...les/paloalto/stix_translation/query_constructor.py 77.74% <0.00%> (-3.23%) ⬇️
...odules/crowdstrike/stix_transmission/api_client.py 47.88% <0.00%> (-1.39%) ⬇️
.../sentinelone/stix_translation/query_constructor.py 63.03% <0.00%> (-1.37%) ⬇️
...es/darktrace/stix_translation/query_constructor.py 78.60% <0.00%> (-0.66%) ⬇️
...bm_security_verify/stix_transmission/api_client.py 16.79% <0.00%> (-0.27%) ⬇️
...s/cybereason/stix_translation/query_constructor.py 76.29% <0.00%> (-0.25%) ⬇️
...odules/elastic_ecs/stix_transmission/api_client.py 13.75% <0.00%> (+0.16%) ⬆️
...urity_verify/stix_translation/query_constructor.py 42.80% <0.00%> (+0.29%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d47f0...ffa8d14. Read the comment docs.

@mdazam1942 mdazam1942 merged commit 6185d7c into opencybersecurityalliance:develop May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splunk connector incorrectly maps network-traffic:dst_ref.value
2 participants