Apply spatial mask across non-spatial dimensions

[colinahill]

This fixes issue #155

[Kirill888]

Instead of using spatial_dims method to get names of spatial dimensions, can you please use xx.odc.ydim to obtain location of the y-axis (x-axis always follows y) and expand rasterized using that.

non_sdims = (*xx.dims[:ydim], xx.dims[ydim+2:])

[robbibt]

Hey @colinahill, I'm not sure it should be necessary to loop over the non-spatial dims - theoretically xarray should handle all that automatically when the code runs this .where() line: https://github.com/opendatacube/odc-geo/blob/develop/odc/geo/_xr_interop.py#L321-L322

I've unfortunately also not been able to reproduce the issue - running something like this on a multi-temporal dataset successfully applies the mask to all timesteps:

[alexgleith]

Closing as it seems it's not necessary and there's been no response from the proposer.