Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume product._md exists #171

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

Ariana-B
Copy link

@Ariana-B Ariana-B commented Sep 3, 2024

A quick and easy fix for #167
The _md attribute is added to the product in infer_dc_product, but if the product is provided via the product_cache rather than inferred, it might not have the attribute (especially since datacube.model.Product does not have it), causing _item_to_ds to fail when it assumes the attribute exists.
Also take the chance to update the use of DatasetType to Product.

Copy link

github-actions bot commented Sep 3, 2024

@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 04:20 Inactive
Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants