Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick and easy fix for #167
The
_md
attribute is added to the product ininfer_dc_product
, but if the product is provided via theproduct_cache
rather than inferred, it might not have the attribute (especially sincedatacube.model.Product
does not have it), causing_item_to_ds
to fail when it assumes the attribute exists.Also take the chance to update the use of
DatasetType
toProduct
.