Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data entity group form bug #779 #782

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Data entity group form bug #779 #782

merged 2 commits into from
Jul 6, 2022

Conversation

NelyDavtyan
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@NelyDavtyan NelyDavtyan added kind: bug Something isn't working scope: frontend Frontend task labels Jun 30, 2022
@NelyDavtyan NelyDavtyan requested a review from Leshe4ka June 30, 2022 12:13
@NelyDavtyan NelyDavtyan requested a review from a team as a code owner June 30, 2022 12:13
@NelyDavtyan NelyDavtyan linked an issue Jun 30, 2022 that may be closed by this pull request
Data entity group form bug #779
Closed
@github-actions

This comment has been minimized.

Sign in to view
Leshe4ka
Leshe4ka approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@Leshe4ka Leshe4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Leshe4ka
Leshe4ka approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@Leshe4ka Leshe4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Test Results

  32 files    32 suites   40s ⏱️
160 tests 160 ✔️ 0 💤 0 ❌
161 runs  161 ✔️ 0 💤 0 ❌

Results for commit 930cbc2.

@NelyDavtyan NelyDavtyan merged commit 22f740c into main Jul 6, 2022
@NelyDavtyan NelyDavtyan deleted the bugfix/779 branch July 6, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leshe4ka Leshe4ka Leshe4ka approved these changes

Assignees
No one assigned
Labels
kind: bug Something isn't working scope: frontend Frontend task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data entity group form bug
2 participants
@NelyDavtyan @Leshe4ka