Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: moving the hardcoded configs in KFPv2 Launcher to configmap. Fixes RHOAIENG-1707 #1

Closed
wants to merge 2 commits into from

Conversation

amadhusu
Copy link

@amadhusu amadhusu commented Jan 12, 2024

Which issue is resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-1707

Description of your changes:
Followed Option 1 in the suggestion mentioned in kubeflow/issues/9689

We want to allow the above configs to be changed from their defaults, preferably on a per-namespace basis.

I propose we add these configs to the ConfigMap/kfp-launcher which already exists in each profile namespace to set defaultPipelineRoot.

For example, a new ConfigMap/kfp-launcher in a profile namespace might look like this:

data:
  defaultPipelineRoot: "minio://mlpipeline/v2/artifacts"
 
  ## minio endpoint config
  defaultMinioEndpoint: "minio.example.com:9000"
 
  ## minio auth configs
  minioAuthConfig: "mlpipeline-minio-artifact"
  minioAuthConfigAccessKey: "access_key"
  minioAuthConfigSecretKey: "access_key"

OPTION 1: have the kfp-launcher container read the ConfigMap/kfp-launcher
when it executes, it can pass the minio configs down as it calls objectstore.OpenBucket

Environment tested:

Checklist:

Achyut Madhusudan added 2 commits January 3, 2024 15:10
Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
Signed-off-by: Achyut Madhusudan <amadhusu@redhat.com>
Copy link

openshift-ci bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rimolive referenced this pull request in rimolive/data-science-pipelines Jan 15, 2024
…10318) (kubeflow#10319)

* feat: preserve querystring in pipeline root

* refactor: create AppendToPipelineRoot
Also apply to client.go

* feat: remove query string from URIs (#1)

* feat: remove query string from URIs

* refactor(GenerateOutputURI): move and preserve comments
@HumairAK
Copy link

closing, we'll follow up with a separate (multiple) prs to resolve these.

@HumairAK HumairAK closed this Jan 15, 2024
rimolive referenced this pull request in rimolive/data-science-pipelines Mar 11, 2024
feat(backend): Add CA injection to step-copy-artifacts step. Fixes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants