UPSTREAM: <carry>: add ns scoped s3 support. #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve RHOAIENG-1707 from dsp side
Description of your changes:
Adds the ability to specify pipeline root based on prefix within a namespace. This pr allows users to:
bucket_session_info
, this is added by the root driver container, so we read the kfp-launcher configmap once per pipelineI would have preferred to organize this very differently but as this is a carried patch I've tried to minimize code deletions to make it easy to merge in upstream changes and minimize conflicts.
Testing changes
Deploy a kfp-launcher configmap that points to your minio/s3/etc:
kfp-launcher-configmap.yaml
Then deploy a dspa in a non
kubeflow
namespace:dspa.yaml