fix: Change image push to use --all-tags option (feast-dev#4926)

change image push to use --all-tags option Signed-off-by: Tommy Hughes <tohughes@redhat.com>
opendatahub-io · Jan 15, 2025 · 02458fd · 02458fd
1 parent 32aaf9a
commit 02458fd
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/.github/workflows/master_only.yml b/.github/workflows/master_only.yml
@@ -97,7 +97,6 @@ jobs:
         component: [ feature-server-dev, feature-transformation-server, feast-operator ]
     env:
       REGISTRY: quay.io/feastdev-ci
-      IMAGE: ${{ matrix.component }}
     steps:
       - uses: actions/checkout@v4
       - name: Set up QEMU
@@ -117,10 +116,10 @@ jobs:
           make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
       - name: Push image
         run: |
-          make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
-
-          if [[ ${{ matrix.component }} == "feature-server-dev" ]]; then
-            echo "IMAGE=feature-server" >> $GITHUB_ENV
+          if [[ "${{ matrix.component }}" == "feature-server-dev" ]]; then
+            docker tag ${REGISTRY}/feature-server:${GITHUB_SHA} ${REGISTRY}/feature-server:develop
+            docker push ${REGISTRY}/feature-server --all-tags
+          else
+            docker tag ${REGISTRY}/${{ matrix.component }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.component }}:develop
+            docker push ${REGISTRY}/${{ matrix.component }} --all-tags
           fi
-          docker tag ${REGISTRY}/${IMAGE}:${GITHUB_SHA} ${REGISTRY}/${IMAGE}:develop
-          docker push ${REGISTRY}/${IMAGE}:develop