Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for authorization feature #253

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Docs for authorization feature #253

merged 1 commit into from
Jun 4, 2024
+318 −0

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:
-->

NONE

Sorry, something went wrong.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Docs for authorization feature

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
4e12777 
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@israel-hdez israel-hdez marked this pull request as ready for review June 3, 2024 18:58
Jooho
Jooho reviewed Jun 4, 2024
View reviewed changes
docs/odh/authorino-setup-manual.md
spec:
action: CUSTOM
provider:
name: opendatahub-auth-provider
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I find this envoyfilter ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not an envoyfilter, it is a configuration in the ServiceMeshControlPlane. See: https://github.com/opendatahub-io/kserve/pull/253/files#diff-649512b8d7a6b58f996c1a23ee4e257cf224998c7ef287cc3b722b8f8c07ddcbR71

Jooho
Jooho reviewed Jun 4, 2024
View reviewed changes
docs/odh/authorino-setup-manual.md

```yaml
spec:
techPreview:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious. Is it still techpreview?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes.

@Jooho Jooho merged commit 601a6e9 into opendatahub-io:master Jun 4, 2024
24 of 26 checks passed
@israel-hdez israel-hdez deleted the k-auth-docs branch June 4, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jooho Jooho

@VedantMahabaleshwarkar VedantMahabaleshwarkar

Assignees
No one assigned
Labels
approved
Projects
ODH Model Serving Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@israel-hdez @Jooho