[pull] master from kserve:master #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
chore: fixes the GH [Alert](https://github.com/kserve/kserve/security/code-scanning/12080). filepath.Clean sanitizes the directory path and remove any unnecessary components (such as . and ..) Signed-off-by: Spolti <fspolti@redhat.com>
|
Hi @pull[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Due to changes in 39b8a67 which added `reinvocationPolicy: IfNeeded` to the WebHook configuration, the injection called can (and will be) called multiple times, and needs to be idempotent (which is a good thing anyway). This commit fixes the array field handling and adding volumes, volumemounts and containers only if they not already had been added. Fixes #3506 Signed-off-by: Roland Huß <rhuss@redhat.com>
Remove redundant helm chart affinity labels: - app.kubernetes.io/managed-by - app.kubernetes.io/instance - app.kubernetes.io/name: with value modelmesh-controller cause affinity to non existent helm chart Signed-off-by: Ondrej Trojan <26576371+trojaond@users.noreply.github.com>
|
/approve |
spolti
approved these changes
Mar 28, 2024
update codeQL to v3 chore: Update CodeQL to V3 to get rid of this warning: `Warning: CodeQL Action v2 will be deprecated on December 5th, 2024` Plus, attenpt to fix the Snyk Container scan failures due errors when trying to upload the SERIF file: `Processing sarif files: ["application/storage-initializer/docker.snyk.sarif"] Uploading results Successfully uploaded results Waiting for processing to finish Error: Code Scanning could not process the submitted SARIF file: could not convert rules: invalid security severity value, is not a number: null ConfigurationError: Code Scanning could not process the submitted SARIF file: could not convert rules: invalid security severity value, is not a number: null at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)` Signed-off-by: Spolti <fspolti@redhat.com>
* switch e2e test inference graph to raw mode Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * download xgb server image Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> --------- Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Pad left for decode-only architecture models. Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
…del_dir (#3559) Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* CVE-2024-24762 - update fastapi to 0.109.1 chore: Fix [CVE-2024-24762](https://www.cve.org/CVERecord?id=CVE-2024-24762) - fastapi Regular Expression Denial of Service (ReDoS) Plus, update Ray to 2.10 to allow updating fastapi. On previous versions of Ray the fastapi version was pinned, which was preventing the fastapi version update. use the new handle api: From Ray Serve docs: Ray 2.7 introduces a new {mod}`DeploymentHandle <ray.serve.handle.DeploymentHandle>` API that will replace the existing `RayServeHandle` and `RayServeSyncHandle` APIs. Signed-off-by: Spolti <fspolti@redhat.com> * add link to about the RayServeHandle deprecation Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Spolti <fspolti@redhat.com>
* wip Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * comment out Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix wf Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * helm test Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * remove mlserver relate tests Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix lint Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * sklearnserver runtime Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Fix test Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * disable check Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * reunused imports Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Add back mlserver Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * pre-commit fix Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * update storage url Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix build Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix codegen Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * revert uri Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * int_contents Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Remove unused script Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * remove dockerfile Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Empty-Commit Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
* Auto-format all Python files Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Use black for linting Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Don't run poetry check on root pyproject.toml Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Re-add flake8 linting Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix linting errors Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Add python path Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix linting Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix circular dependency Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Fix circular dependency Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> --------- Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Spolti <fspolti@redhat.com>
|
/test |
|
@spolti: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-raw |
…3558) * support model revision and tokenizer revision Signed-off-by: Lize Cai <lize.cai@sap.com> * point to specified commit in test case Signed-off-by: Lize Cai <lize.cai@sap.com> * format code Signed-off-by: Lize Cai <lize.cai@sap.com> --------- Signed-off-by: Lize Cai <lize.cai@sap.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
|
/test all |
|
/lgtm |
spolti
approved these changes
Apr 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pull[bot], spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* OpenAI data models and endpoints from vLLM Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * more components for OpenAI endpoints Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add OpenAI endpoints to router Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * modify generate() in data plane Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * class OpenAIModel Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * delete and rename files Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add create_chat_completion() to OpenAIModel Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * update routers and lint Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * Implement streaming Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Add tests for OpenAI data conversion Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Register OpenAI endpoints when appropriate Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Add comments Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Add tests for create_completion and create_chat_completion Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * Remove completion types from dataplane methods Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * WIP Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> * fix lint errors Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * update poetry.lock Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * update poetry.lock files Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add dependency Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix test Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * revert poetry.lock files Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add .itermconfig to .gitignore Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add docker-compose.yml to .gitignore Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix build error Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix function descriptions Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * increase limit for model decompression size Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add license & autoformat Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * make openai dependency mandatory Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * openai dependency back to optional Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix openai module import error Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix JSON unmarshalling of headers Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * drop formatting changes in unrelated files Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix openai_is_available() Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * black reformat Signed-off-by: Tessa Pham <hpham111@bloomberg.net> --------- Signed-off-by: Tessa Pham <hpham111@bloomberg.net> Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net> Co-authored-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
|
/lgtm |
* Fix python linter Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Format e2e tests Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Format hack, docs Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Add py-fmt target Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update python lint workflow Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Rebase master Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
|
New changes are detected. LGTM label has been removed. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
moved to #289 due conflict |
israel-hdez
pushed a commit
to israel-hdez/kserve
that referenced
this pull request
May 20, 2024
…htly Updating kserve nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )