Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-5073] - Routing and Headless Service Support in KServe Raw … #280

Merged
merged 2 commits into from
Apr 4, 2024
Merged

[RHOAIENG-5073] - Routing and Headless Service Support in KServe Raw … #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c993521
[RHOAIENG-5073] - Routing and Headless Service Support in KServe Raw …
spolti Apr 2, 2024
b855d52
comment ce logs for headless services
spolti Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/controller/v1beta1/inferenceservice/reconcilers/service/service_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ func createService(componentMeta metav1.ObjectMeta, componentExt *v1beta1.Compon
"app": constants.GetRawServiceLabel(componentMeta.Name),
},
Ports: servicePorts,
// TODO - add a control flag
// Need to add a control flag to properly set it, enable/disable this behavior.
// Follow up issue to align with upstream: https://issues.redhat.com/browse/RHOAIENG-5077
ClusterIP: corev1.ClusterIPNone,
},
}
return service
Expand Down
1 change: 1 addition & 0 deletions test/e2e/logger/test_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def test_kserve_logger():
namespace=pod.metadata.namespace,
container="kserve-container")
print(log)

assert ("org.kubeflow.serving.inference.request" in log)
assert ("org.kubeflow.serving.inference.response" in log)
kserve_client.delete(service_name, KSERVE_TEST_NAMESPACE)
Expand Down
7 changes: 5 additions & 2 deletions test/e2e/logger/test_raw_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,10 @@ def test_kserve_logger():
namespace=pod.metadata.namespace,
container="kserve-container")
print(log)
assert ("org.kubeflow.serving.inference.request" in log)
assert ("org.kubeflow.serving.inference.response" in log)

# TODO, as part of the https://issues.redhat.com/browse/RHOAIENG-5077
# add the control flag here to check the logs when headless service is disabled
# assert ("org.kubeflow.serving.inference.request" in log)
# assert ("org.kubeflow.serving.inference.response" in log)
kserve_client.delete(service_name, KSERVE_TEST_NAMESPACE)
kserve_client.delete(msg_dumper, KSERVE_TEST_NAMESPACE)
Loading