Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kserve:master #361

Merged
merged 12 commits into from
Jun 7, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented May 21, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Signed-off-by: Vincent Hou <shou73@bloomberg.net>
Copy link

openshift-ci bot commented May 21, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sivanantha321 and others added 11 commits May 22, 2024 07:32
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
fix conflict

Signed-off-by: jooho <jlee@redhat.com>
* Add precaution again running v1 endpoints on openai models

Signed-off-by: grandbora <grandbora@fb.com>

* Remove the check from explain

Signed-off-by: grandbora <grandbora@fb.com>

* Add a warning log for explain

Signed-off-by: grandbora <grandbora@fb.com>

---------

Signed-off-by: grandbora <grandbora@fb.com>
* Add FP16 datatype support for OIP grpc
Add grpc server tests

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add grpcio-testing as test dependency

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Fix model repository initialization default value

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Remove fp16 global map

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Resolve comments

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* added flag to return raw prediction results

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* black fix

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* unit test bug fix

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* unittest for token classification

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* verify codegen

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* bug fix

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Signed-off-by: Alex Peters <alpe@users.noreply.github.com>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Fix model_id and model_dir precendence

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
* Fixup max_length for HF and model info for vLLM

Signed-off-by: Dattu Sharma <venkatadattasainimmaturi@gmail.com>

* Use vLLM's implementation for max_length

Also fixup error in calculating input sequence lenngth

Signed-off-by: Dattu Sharma <venkatadattasainimmaturi@gmail.com>

* Fixup linter

Signed-off-by: Dattu Sharma <venkatadattasainimmaturi@gmail.com>

* Add license to new file

Signed-off-by: Dattu Sharma <venkatadattasainimmaturi@gmail.com>

* Add bloom test case for max_tokens

Revert input length fix

Signed-off-by: Dattu Sharma <venkatadattasainimmaturi@gmail.com>

* Set limit on opt chat competion e2e test

Signed-off-by: Dattu Sharma <venkatadattasainimmaturi@gmail.com>

---------

Signed-off-by: Dattu Sharma <venkatadattasainimmaturi@gmail.com>
#3712)

* Fix input token count and add completion usage

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Add max_length for test models

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
update version to 0.13.0

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
@israel-hdez
Copy link

/ok-to-test

Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, pull[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 97c83cf into opendatahub-io:master Jun 7, 2024
26 checks passed
Jooho pushed a commit to Jooho/kserve that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

9 participants